[GitHub] [wicket] theigl opened a new pull request #452: WICKET-6830 Convert `Behaviors` into a static utility

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [wicket] theigl opened a new pull request #452: WICKET-6830 Convert `Behaviors` into a static utility

GitBox

theigl opened a new pull request #452:
URL: https://github.com/apache/wicket/pull/452


   We currently create a `Behaviors` instance for every invocation of its methods. While this is slightly "more OO" than a static utility class, it allocates hundreds of MiB per minute in my application.
   
   This PR converts `Behaviors` into a static utility class.
   
   See https://issues.apache.org/jira/browse/WICKET-6830


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [wicket] theigl commented on pull request #452: WICKET-6830 Convert `Behaviors` into a static utility

GitBox

theigl commented on pull request #452:
URL: https://github.com/apache/wicket/pull/452#issuecomment-692144942


   @martin-g: The build does not fail for me. `Behaviors` is a package private, final class. This should not affect the public API at all, or am I missing something?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [wicket] svenmeier commented on pull request #452: WICKET-6830 Convert `Behaviors` into a static utility

GitBox
In reply to this post by GitBox

svenmeier commented on pull request #452:
URL: https://github.com/apache/wicket/pull/452#issuecomment-692183968


   I thought so too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [wicket] martin-g commented on pull request #452: WICKET-6830 Convert `Behaviors` into a static utility

GitBox
In reply to this post by GitBox

martin-g commented on pull request #452:
URL: https://github.com/apache/wicket/pull/452#issuecomment-692192605


   Ah, OK!
   Then it should be good!
   
   On Mon, Sep 14, 2020, 18:46 Thomas Heigl <[hidden email]> wrote:
   
   > @martin-g <https://github.com/martin-g>: The build does not fail for me.
   > Behaviors is a package private, final class. This should not affect the
   > public API at all, or am I missing something?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/wicket/pull/452#issuecomment-692144942>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AABYUQSDYKF3ZX2CA4FT6WLSFY3HDANCNFSM4RKRVVCA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [wicket] theigl merged pull request #452: WICKET-6830 Convert `Behaviors` into a static utility

GitBox
In reply to this post by GitBox

theigl merged pull request #452:
URL: https://github.com/apache/wicket/pull/452


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]