UPDATE: Igor Vaynberg has commented on the JIRA issue. He states that the code is correct.
I will immediately admit that I am no Wicket expert by far, so I could be wrong. But I am sure I see the problem with the busy indicator happening; it never stops spinning. So if the code generated by AbstractDefaultAjaxBehavior is correct, there must be something wrong in the way we use it.
Here is the javascript code, copied from the link around the icon that, once clicked, causes the busy indicator to spin. An AJAX request is fired and the response is handled correctly. All is as expected except for the busy indicator, which never stops spinning.
(I split it up in an attempt to improve on the readability)
HTML:
------
<A id=actionButton6586 class=actionButton onclick="<javascript code>" href="<url>" wicketFocusSet="true">
<SPAN class=actionButtonLabel title=Acquired>Acquired</SPAN>
</A>
Javascript code:
----------------
if (function() {return Wicket.$('actionButton6586') != null;}()) {
Wicket.showIncrementally('busy');
}
var wcall=wicketAjaxGet(
'<url>',
function() { ;Wicket.hideIncrementally('busy');}.bind(this),
function() { ;Wicket.hideIncrementally('busy');}.bind(this),
function() {return Wicket.$('actionButton6586') != null;}.bind(this)
);
return !wcall;
The original fragment is below for reference.
The icon button that this Javascript is on is part of a dialog that closes once the button is pressed. I now suspect that may be the cause of the problem?
Here is the Java code we use to create this dialog and make it IAjaxIndicatorAware.
Java code (just the most important stuff):
-----------------------------------------
public abstract class PlanonWebBaseDialog extends PnWebGenericWebBaseDialog implements IModalDialogManager
{
protected class DialogButton extends PnWebButton implements IAjaxIndicatorAware
{
public final String getAjaxIndicatorMarkupId()
{
return getAjaxIndicatorId();
}
private void onClick() throws PnErrorListException, AuthorizationException
{
// Do not fire button events when an other dialog is showing
// Happens when pressing the button triggers the showing of another dialog
if (!hasDialog() && doAction())
{
close(PnSession.getAjaxRequestTarget());
}
}
}
// ...
}
So the base class we use for a dialog has a DialogButton nested class that implements IAjaxIndicatorAware. The actual dialogs in our application are subclasses of this class and instantiate DialogButtons for the OK and Cancel buttons etc.
The getAjaxIndicatorId is on the dialog itself and searches for the parent element that is IAjaxIndicatorAware and delegates to it's getAjaxIndicatorMarkupId to finally determine the markup ID of the busy indicator that is on the main page.
I suspect we may have done something wrong there, because if I change the dialog and DialogButton in such a way that PlanonWebBaseDialog implements IAjaxIndicatorAware instead of the DialogButton, the issue with the busy indicator spinning forever disappears.
Can you see from the generated markup whether we are returning the correct indicator markup ID?
Can you explain why moving the 'implements IAjaxIndicatorAware' from the button to the dialog itself solves the issue?
Sorry for polluting JIRA. :)
Original fragment:
-----------------
<A id=actionButton6586 class=actionButton onclick="if (function(){return Wicket.$('actionButton6586') != null;}()) { Wicket.showIncrementally('busy');}var wcall=wicketAjaxGet('?wicket:interface=:17:modalWindow:content:buttonForm:actionOnSelectionPanel:actionGroupList:2:actionList:1:actionButton::IBehaviorListener:0:-1',function() { ;Wicket.hideIncrementally('busy');}.bind(this),function() { ;Wicket.hideIncrementally('busy');}.bind(this), function() {return Wicket.$('actionButton6586') != null;}.bind(this));return !wcall;" href="
http://localhost:8070/Hera/clientWithLaunchCenter/?wicket:interface=:17:modalWindow:content:buttonForm:actionOnSelectionPanel:actionGroupList:2:actionList:1:actionButton::ILinkListener::" wicketFocusSet="true"><SPAN class=actionButtonLabel title=Acquired>Acquired</SPAN></A>
With kind regards,
-
Stijn
Sometimes big things come in small packages
Locked
