Quantcast

[VOTE] Release Apache Wicket 7.7.0

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[VOTE] Release Apache Wicket 7.7.0

Andrea Del Bene-3
This is a vote to release Apache Wicket 7.7.0

Please download the source distributions found in our staging area
linked below.

I have included the signatures for both the source archives. This vote
lasts for 72 hours minimum.

[ ] Yes, release Apache Wicket 7.7.0
[ ] No, don't release Apache Wicket 7.7.0, because ...

Distributions, changelog, keys and signatures can be found at:

     https://dist.apache.org/repos/dist/dev/wicket/7.7.0

Staging repository:

https://repository.apache.org/content/repositories/orgapachewicket-1087

The binaries are available in the above link, as are a staging
repository for Maven. Typically the vote is on the source, but should
you find a problem with one of the binaries, please let me know, I can
re-roll them some way or the other.

Staging git repository data:

     Repository:  [hidden email]:bitstorm/wicket.git
     Branch:      build/wicket-7.7.0
     Release tag: rel/wicket-7.7.0


========================================================================

     The signatures for the source release artefacts:


Signature for apache-wicket-7.7.0.zip:

     -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBVsVQP/R2Qky5zUL83DnwM0Pq0He8h
aCud1d/MAduEekPKNSnxIF7Tv1ild5/B1QXGjmkhiil3V1WjNUxc8ytY9TFN+jRe
jyFYlVR1pMucPwQWgJXFP/kgsqIzv1OPnjKX0k6DTafwfJ7rpZh6AO5NVy9SChO3
eZE2woeFb799+GuHif0hzin405IR5XohK+gwCzmSbmONpHP/2SxwDLi8kIC1+Xjz
vfRTLXLlW26DA8Wqk7d6OLqJ69GXisgNkd1bFJy4TxUksVj+eos8bhFMjFEjZJsB
2i4+UnoBMhunIlMbD42SZR9v7SwffLnfMet0UgMT5P5fcJYtPtl1NH172pkoxyra
cC5/80kmbFhgjGZnlFj55IRD2m015r36cIAuK+fkGrPjgUr4k18CZK/yi1HIgsnp
pSyS9E5yRkeNclkqjIBmzFStF9GWEC/xvW7HJ5I8zoeyTt5Uo+Yh7pqcdHUhbXUH
l1F+Pp4tsZJRFx3nCw/Ng6NKC1tBHD4iTQKXQLvCOQBEZQQIMuCNTcMcErvZse+e
p8tMh6UbCD8sptrhNcC6Z3IQ0cXwvKzRcGEaiFeWqFXPq1lurnQWGT1bhoVMOaMM
891QYsRcIzIdh3/QDU1Z0I9it7l8+qto+6m4vLQWrWbHEneOd3sShazjzDdeOzXQ
pBgjyRq1L2Z6OvTR5Guy
=6eiD
-----END PGP SIGNATURE-----

Signature for apache-wicket-7.7.0.tar.gz:

     -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBV1bsP/jTtw3CU7pDGyQ0RYlnfi6+r
M/etf1DVxZM3xU/tcvFljA75HQWt6v+CHkg+egw+z8jCsAQwxAxQ7NmjRwIfTPEO
9Kypmb3v3j8RkbbmH3pn0KEp+SHadMsgDolpXt5EVqSbfToR2n+VpRtuq7MvCEqx
NSCeRqhB1iZciUQQm/sf6/kddW27sqw6wZ6Tt8zZfhiImd+DRNpQzdL1YPsE1w6r
Opf67v22vITUJfDrOvEMwVey8zb+dgQiqcKOZcpG/V3z2OvJFyyw5Q95VXzV0+ho
e1wD/6fa5hck6XRKPhsEValaQMU15dmSyR0tjPGqN6i0LgE2WIQ97copj1erDQ26
RlBIipc2desEOh+s4vAFUKew1Ll0ept82mvpzbVClHwxWblyyGtKQrHZbAgdVC9k
qpKrlRLZxRP2bisEobl9bjr3tUGy9iqpkZXqYnRRmaewGryExmm1T12ndRvNjgZN
ZoT49+vTvlRW+Ocszv4m6kcMitHt3yLVXcnhqWMCBiWvdwDG6FdSUvUnwskyvvQo
l1OhD7IOTNhz+hAlFn+x9h1jsgHzjY2I8Ys4I4QzLlgYkGy/0k6AcwG3hFNN4pS1
HNpiSYhbFoDrlzLa4V+lOikARL8WJwjnpqOF32T96cKRrnhFwnZufWMaCYYKjwbs
hi3qkSvtkCPUUy1iPRT8
=RLxY
-----END PGP SIGNATURE-----

========================================================================

     CHANGELOG for 7.7.0:

** Bug

     * [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore vs.
MarkupStream.next.
     * [WICKET-6303] - renderHead method of a Behavior added to a Border
body is not called
     * [WICKET-6306] - Changing model object of Panel added to a Border
not allowed
     * [WICKET-6311] - SignOutPage_ru.html is missing
     * [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms
     * [WICKET-6316] - Wicket tester encodes page id for stateless links
in stateless pages
     * [WICKET-6317] - AuthenticatedWebSession#signOut() calls twice
after session invalidation
     * [WICKET-6319] - AutoCompleteTextField: popup is hidden when
clicking on scrollbar in IE
     * [WICKET-6332] - NullPointerException in PageParameters#equals()
     * [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates
invalid XHTML markup for multipart forms
     * [WICKET-6342] - Wrong baseUrl in BaseWebSocketBehavior
     * [WICKET-6349] - Stateless form does not work when
RecreateBookmarkablePagesAfterExpiry is false
     * [WICKET-6353] - Proxy deserialization fails due to classloading
issues

** Improvement

     * [WICKET-6212] - CheckChoice / add a getAdditionalAttributes()
also for <label>-tag
     * [WICKET-6265] - Make it possible to authorize component
instantiations both with OR and AND rules
     * [WICKET-6307] - SubmitLink does not work in Chrome "ff.onsubmit
is not a function"
     * [WICKET-6308] - Add an extra constructor to EmailTextField with a
custom validator but without model
     * [WICKET-6323] - Allow ResourceBundles to use the defer attribute
     * [WICKET-6328] - Add 'pathInfo' to ForwardAttributes
     * [WICKET-6333] - Use onConfigure() to set the visibility of
ExportToolbar instead of overriding isVisible()
     * [WICKET-6351] - Form.anyFormComponentError performance degradation

** Task

     * [WICKET-6287] - Switch from json.org to open-json

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Tobias Soloschenko
+1

kind regards

Tobias

> Am 15.04.2017 um 22:38 schrieb Andrea Del Bene <[hidden email]>:
>
> This is a vote to release Apache Wicket 7.7.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 7.7.0
> [ ] No, don't release Apache Wicket 7.7.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
>    https://dist.apache.org/repos/dist/dev/wicket/7.7.0
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1087
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
>    Repository:  [hidden email]:bitstorm/wicket.git
>    Branch:      build/wicket-7.7.0
>    Release tag: rel/wicket-7.7.0
>
>
> ========================================================================
>
>    The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-7.7.0.zip:
>
>    -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBVsVQP/R2Qky5zUL83DnwM0Pq0He8h
> aCud1d/MAduEekPKNSnxIF7Tv1ild5/B1QXGjmkhiil3V1WjNUxc8ytY9TFN+jRe
> jyFYlVR1pMucPwQWgJXFP/kgsqIzv1OPnjKX0k6DTafwfJ7rpZh6AO5NVy9SChO3
> eZE2woeFb799+GuHif0hzin405IR5XohK+gwCzmSbmONpHP/2SxwDLi8kIC1+Xjz
> vfRTLXLlW26DA8Wqk7d6OLqJ69GXisgNkd1bFJy4TxUksVj+eos8bhFMjFEjZJsB
> 2i4+UnoBMhunIlMbD42SZR9v7SwffLnfMet0UgMT5P5fcJYtPtl1NH172pkoxyra
> cC5/80kmbFhgjGZnlFj55IRD2m015r36cIAuK+fkGrPjgUr4k18CZK/yi1HIgsnp
> pSyS9E5yRkeNclkqjIBmzFStF9GWEC/xvW7HJ5I8zoeyTt5Uo+Yh7pqcdHUhbXUH
> l1F+Pp4tsZJRFx3nCw/Ng6NKC1tBHD4iTQKXQLvCOQBEZQQIMuCNTcMcErvZse+e
> p8tMh6UbCD8sptrhNcC6Z3IQ0cXwvKzRcGEaiFeWqFXPq1lurnQWGT1bhoVMOaMM
> 891QYsRcIzIdh3/QDU1Z0I9it7l8+qto+6m4vLQWrWbHEneOd3sShazjzDdeOzXQ
> pBgjyRq1L2Z6OvTR5Guy
> =6eiD
> -----END PGP SIGNATURE-----
>
> Signature for apache-wicket-7.7.0.tar.gz:
>
>    -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBV1bsP/jTtw3CU7pDGyQ0RYlnfi6+r
> M/etf1DVxZM3xU/tcvFljA75HQWt6v+CHkg+egw+z8jCsAQwxAxQ7NmjRwIfTPEO
> 9Kypmb3v3j8RkbbmH3pn0KEp+SHadMsgDolpXt5EVqSbfToR2n+VpRtuq7MvCEqx
> NSCeRqhB1iZciUQQm/sf6/kddW27sqw6wZ6Tt8zZfhiImd+DRNpQzdL1YPsE1w6r
> Opf67v22vITUJfDrOvEMwVey8zb+dgQiqcKOZcpG/V3z2OvJFyyw5Q95VXzV0+ho
> e1wD/6fa5hck6XRKPhsEValaQMU15dmSyR0tjPGqN6i0LgE2WIQ97copj1erDQ26
> RlBIipc2desEOh+s4vAFUKew1Ll0ept82mvpzbVClHwxWblyyGtKQrHZbAgdVC9k
> qpKrlRLZxRP2bisEobl9bjr3tUGy9iqpkZXqYnRRmaewGryExmm1T12ndRvNjgZN
> ZoT49+vTvlRW+Ocszv4m6kcMitHt3yLVXcnhqWMCBiWvdwDG6FdSUvUnwskyvvQo
> l1OhD7IOTNhz+hAlFn+x9h1jsgHzjY2I8Ys4I4QzLlgYkGy/0k6AcwG3hFNN4pS1
> HNpiSYhbFoDrlzLa4V+lOikARL8WJwjnpqOF32T96cKRrnhFwnZufWMaCYYKjwbs
> hi3qkSvtkCPUUy1iPRT8
> =RLxY
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
>    CHANGELOG for 7.7.0:
>
> ** Bug
>
>    * [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore vs. MarkupStream.next.
>    * [WICKET-6303] - renderHead method of a Behavior added to a Border body is not called
>    * [WICKET-6306] - Changing model object of Panel added to a Border not allowed
>    * [WICKET-6311] - SignOutPage_ru.html is missing
>    * [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms
>    * [WICKET-6316] - Wicket tester encodes page id for stateless links in stateless pages
>    * [WICKET-6317] - AuthenticatedWebSession#signOut() calls twice after session invalidation
>    * [WICKET-6319] - AutoCompleteTextField: popup is hidden when clicking on scrollbar in IE
>    * [WICKET-6332] - NullPointerException in PageParameters#equals()
>    * [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates invalid XHTML markup for multipart forms
>    * [WICKET-6342] - Wrong baseUrl in BaseWebSocketBehavior
>    * [WICKET-6349] - Stateless form does not work when RecreateBookmarkablePagesAfterExpiry is false
>    * [WICKET-6353] - Proxy deserialization fails due to classloading issues
>
> ** Improvement
>
>    * [WICKET-6212] - CheckChoice / add a getAdditionalAttributes() also for <label>-tag
>    * [WICKET-6265] - Make it possible to authorize component instantiations both with OR and AND rules
>    * [WICKET-6307] - SubmitLink does not work in Chrome "ff.onsubmit is not a function"
>    * [WICKET-6308] - Add an extra constructor to EmailTextField with a custom validator but without model
>    * [WICKET-6323] - Allow ResourceBundles to use the defer attribute
>    * [WICKET-6328] - Add 'pathInfo' to ForwardAttributes
>    * [WICKET-6333] - Use onConfigure() to set the visibility of ExportToolbar instead of overriding isVisible()
>    * [WICKET-6351] - Form.anyFormComponentError performance degradation
>
> ** Task
>
>    * [WICKET-6287] - Switch from json.org to open-json
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Andrea Del Bene-3
In reply to this post by Andrea Del Bene-3
+1 to release

Andrea.

On 15/04/2017 22:38, Andrea Del Bene wrote:

> This is a vote to release Apache Wicket 7.7.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 7.7.0
> [ ] No, don't release Apache Wicket 7.7.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
>     https://dist.apache.org/repos/dist/dev/wicket/7.7.0
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1087
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
>     Repository:  [hidden email]:bitstorm/wicket.git
>     Branch:      build/wicket-7.7.0
>     Release tag: rel/wicket-7.7.0
>
>
> ========================================================================
>
>     The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-7.7.0.zip:
>
>     -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBVsVQP/R2Qky5zUL83DnwM0Pq0He8h
> aCud1d/MAduEekPKNSnxIF7Tv1ild5/B1QXGjmkhiil3V1WjNUxc8ytY9TFN+jRe
> jyFYlVR1pMucPwQWgJXFP/kgsqIzv1OPnjKX0k6DTafwfJ7rpZh6AO5NVy9SChO3
> eZE2woeFb799+GuHif0hzin405IR5XohK+gwCzmSbmONpHP/2SxwDLi8kIC1+Xjz
> vfRTLXLlW26DA8Wqk7d6OLqJ69GXisgNkd1bFJy4TxUksVj+eos8bhFMjFEjZJsB
> 2i4+UnoBMhunIlMbD42SZR9v7SwffLnfMet0UgMT5P5fcJYtPtl1NH172pkoxyra
> cC5/80kmbFhgjGZnlFj55IRD2m015r36cIAuK+fkGrPjgUr4k18CZK/yi1HIgsnp
> pSyS9E5yRkeNclkqjIBmzFStF9GWEC/xvW7HJ5I8zoeyTt5Uo+Yh7pqcdHUhbXUH
> l1F+Pp4tsZJRFx3nCw/Ng6NKC1tBHD4iTQKXQLvCOQBEZQQIMuCNTcMcErvZse+e
> p8tMh6UbCD8sptrhNcC6Z3IQ0cXwvKzRcGEaiFeWqFXPq1lurnQWGT1bhoVMOaMM
> 891QYsRcIzIdh3/QDU1Z0I9it7l8+qto+6m4vLQWrWbHEneOd3sShazjzDdeOzXQ
> pBgjyRq1L2Z6OvTR5Guy
> =6eiD
> -----END PGP SIGNATURE-----
>
> Signature for apache-wicket-7.7.0.tar.gz:
>
>     -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBV1bsP/jTtw3CU7pDGyQ0RYlnfi6+r
> M/etf1DVxZM3xU/tcvFljA75HQWt6v+CHkg+egw+z8jCsAQwxAxQ7NmjRwIfTPEO
> 9Kypmb3v3j8RkbbmH3pn0KEp+SHadMsgDolpXt5EVqSbfToR2n+VpRtuq7MvCEqx
> NSCeRqhB1iZciUQQm/sf6/kddW27sqw6wZ6Tt8zZfhiImd+DRNpQzdL1YPsE1w6r
> Opf67v22vITUJfDrOvEMwVey8zb+dgQiqcKOZcpG/V3z2OvJFyyw5Q95VXzV0+ho
> e1wD/6fa5hck6XRKPhsEValaQMU15dmSyR0tjPGqN6i0LgE2WIQ97copj1erDQ26
> RlBIipc2desEOh+s4vAFUKew1Ll0ept82mvpzbVClHwxWblyyGtKQrHZbAgdVC9k
> qpKrlRLZxRP2bisEobl9bjr3tUGy9iqpkZXqYnRRmaewGryExmm1T12ndRvNjgZN
> ZoT49+vTvlRW+Ocszv4m6kcMitHt3yLVXcnhqWMCBiWvdwDG6FdSUvUnwskyvvQo
> l1OhD7IOTNhz+hAlFn+x9h1jsgHzjY2I8Ys4I4QzLlgYkGy/0k6AcwG3hFNN4pS1
> HNpiSYhbFoDrlzLa4V+lOikARL8WJwjnpqOF32T96cKRrnhFwnZufWMaCYYKjwbs
> hi3qkSvtkCPUUy1iPRT8
> =RLxY
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
>     CHANGELOG for 7.7.0:
>
> ** Bug
>
>     * [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore
> vs. MarkupStream.next.
>     * [WICKET-6303] - renderHead method of a Behavior added to a
> Border body is not called
>     * [WICKET-6306] - Changing model object of Panel added to a Border
> not allowed
>     * [WICKET-6311] - SignOutPage_ru.html is missing
>     * [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms
>     * [WICKET-6316] - Wicket tester encodes page id for stateless
> links in stateless pages
>     * [WICKET-6317] - AuthenticatedWebSession#signOut() calls twice
> after session invalidation
>     * [WICKET-6319] - AutoCompleteTextField: popup is hidden when
> clicking on scrollbar in IE
>     * [WICKET-6332] - NullPointerException in PageParameters#equals()
>     * [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates
> invalid XHTML markup for multipart forms
>     * [WICKET-6342] - Wrong baseUrl in BaseWebSocketBehavior
>     * [WICKET-6349] - Stateless form does not work when
> RecreateBookmarkablePagesAfterExpiry is false
>     * [WICKET-6353] - Proxy deserialization fails due to classloading
> issues
>
> ** Improvement
>
>     * [WICKET-6212] - CheckChoice / add a getAdditionalAttributes()
> also for <label>-tag
>     * [WICKET-6265] - Make it possible to authorize component
> instantiations both with OR and AND rules
>     * [WICKET-6307] - SubmitLink does not work in Chrome "ff.onsubmit
> is not a function"
>     * [WICKET-6308] - Add an extra constructor to EmailTextField with
> a custom validator but without model
>     * [WICKET-6323] - Allow ResourceBundles to use the defer attribute
>     * [WICKET-6328] - Add 'pathInfo' to ForwardAttributes
>     * [WICKET-6333] - Use onConfigure() to set the visibility of
> ExportToolbar instead of overriding isVisible()
>     * [WICKET-6351] - Form.anyFormComponentError performance degradation
>
> ** Task
>
>     * [WICKET-6287] - Switch from json.org to open-json
>

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Martin Grigorov-4
In reply to this post by Andrea Del Bene-3
[ X ] Yes, release Apache Wicket 7.7.0

Tested:
- build from source
- Wicket JQuery Selectors, Webjars && Bootstrap
- Build and stage WicketStuff
- my daily job main application

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sat, Apr 15, 2017 at 10:38 PM, Andrea Del Bene <[hidden email]>
wrote:

> This is a vote to release Apache Wicket 7.7.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 7.7.0
> [ ] No, don't release Apache Wicket 7.7.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
>     https://dist.apache.org/repos/dist/dev/wicket/7.7.0
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachewicket-1087
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
>     Repository:  [hidden email]:bitstorm/wicket.git
>     Branch:      build/wicket-7.7.0
>     Release tag: rel/wicket-7.7.0
>
>
> ========================================================================
>
>     The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-7.7.0.zip:
>
>     -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBVsVQP/R2Qky5zUL83DnwM0Pq0He8h
> aCud1d/MAduEekPKNSnxIF7Tv1ild5/B1QXGjmkhiil3V1WjNUxc8ytY9TFN+jRe
> jyFYlVR1pMucPwQWgJXFP/kgsqIzv1OPnjKX0k6DTafwfJ7rpZh6AO5NVy9SChO3
> eZE2woeFb799+GuHif0hzin405IR5XohK+gwCzmSbmONpHP/2SxwDLi8kIC1+Xjz
> vfRTLXLlW26DA8Wqk7d6OLqJ69GXisgNkd1bFJy4TxUksVj+eos8bhFMjFEjZJsB
> 2i4+UnoBMhunIlMbD42SZR9v7SwffLnfMet0UgMT5P5fcJYtPtl1NH172pkoxyra
> cC5/80kmbFhgjGZnlFj55IRD2m015r36cIAuK+fkGrPjgUr4k18CZK/yi1HIgsnp
> pSyS9E5yRkeNclkqjIBmzFStF9GWEC/xvW7HJ5I8zoeyTt5Uo+Yh7pqcdHUhbXUH
> l1F+Pp4tsZJRFx3nCw/Ng6NKC1tBHD4iTQKXQLvCOQBEZQQIMuCNTcMcErvZse+e
> p8tMh6UbCD8sptrhNcC6Z3IQ0cXwvKzRcGEaiFeWqFXPq1lurnQWGT1bhoVMOaMM
> 891QYsRcIzIdh3/QDU1Z0I9it7l8+qto+6m4vLQWrWbHEneOd3sShazjzDdeOzXQ
> pBgjyRq1L2Z6OvTR5Guy
> =6eiD
> -----END PGP SIGNATURE-----
>
> Signature for apache-wicket-7.7.0.tar.gz:
>
>     -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQIcBAABAgAGBQJY8mzSAAoJEAzCjx+CMhBV1bsP/jTtw3CU7pDGyQ0RYlnfi6+r
> M/etf1DVxZM3xU/tcvFljA75HQWt6v+CHkg+egw+z8jCsAQwxAxQ7NmjRwIfTPEO
> 9Kypmb3v3j8RkbbmH3pn0KEp+SHadMsgDolpXt5EVqSbfToR2n+VpRtuq7MvCEqx
> NSCeRqhB1iZciUQQm/sf6/kddW27sqw6wZ6Tt8zZfhiImd+DRNpQzdL1YPsE1w6r
> Opf67v22vITUJfDrOvEMwVey8zb+dgQiqcKOZcpG/V3z2OvJFyyw5Q95VXzV0+ho
> e1wD/6fa5hck6XRKPhsEValaQMU15dmSyR0tjPGqN6i0LgE2WIQ97copj1erDQ26
> RlBIipc2desEOh+s4vAFUKew1Ll0ept82mvpzbVClHwxWblyyGtKQrHZbAgdVC9k
> qpKrlRLZxRP2bisEobl9bjr3tUGy9iqpkZXqYnRRmaewGryExmm1T12ndRvNjgZN
> ZoT49+vTvlRW+Ocszv4m6kcMitHt3yLVXcnhqWMCBiWvdwDG6FdSUvUnwskyvvQo
> l1OhD7IOTNhz+hAlFn+x9h1jsgHzjY2I8Ys4I4QzLlgYkGy/0k6AcwG3hFNN4pS1
> HNpiSYhbFoDrlzLa4V+lOikARL8WJwjnpqOF32T96cKRrnhFwnZufWMaCYYKjwbs
> hi3qkSvtkCPUUy1iPRT8
> =RLxY
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
>     CHANGELOG for 7.7.0:
>
> ** Bug
>
>     * [WICKET-6165] - Inconsistent behavior of Markupstream.hasMore vs.
> MarkupStream.next.
>     * [WICKET-6303] - renderHead method of a Behavior added to a Border
> body is not called
>     * [WICKET-6306] - Changing model object of Panel added to a Border not
> allowed
>     * [WICKET-6311] - SignOutPage_ru.html is missing
>     * [WICKET-6314] - 7.6 release references 7.5-SNAPSHOT poms
>     * [WICKET-6316] - Wicket tester encodes page id for stateless links in
> stateless pages
>     * [WICKET-6317] - AuthenticatedWebSession#signOut() calls twice after
> session invalidation
>     * [WICKET-6319] - AutoCompleteTextField: popup is hidden when clicking
> on scrollbar in IE
>     * [WICKET-6332] - NullPointerException in PageParameters#equals()
>     * [WICKET-6340] - The Ajax reponse of an AjaxSubmitButton creates
> invalid XHTML markup for multipart forms
>     * [WICKET-6342] - Wrong baseUrl in BaseWebSocketBehavior
>     * [WICKET-6349] - Stateless form does not work when
> RecreateBookmarkablePagesAfterExpiry is false
>     * [WICKET-6353] - Proxy deserialization fails due to classloading
> issues
>
> ** Improvement
>
>     * [WICKET-6212] - CheckChoice / add a getAdditionalAttributes() also
> for <label>-tag
>     * [WICKET-6265] - Make it possible to authorize component
> instantiations both with OR and AND rules
>     * [WICKET-6307] - SubmitLink does not work in Chrome "ff.onsubmit is
> not a function"
>     * [WICKET-6308] - Add an extra constructor to EmailTextField with a
> custom validator but without model
>     * [WICKET-6323] - Allow ResourceBundles to use the defer attribute
>     * [WICKET-6328] - Add 'pathInfo' to ForwardAttributes
>     * [WICKET-6333] - Use onConfigure() to set the visibility of
> ExportToolbar instead of overriding isVisible()
>     * [WICKET-6351] - Form.anyFormComponentError performance degradation
>
>
> ** Task
>
>     * [WICKET-6287] - Switch from json.org to open-json
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Sebastien
I will try to test out tonight!

On Tue, Apr 18, 2017 at 1:33 AM, Martin Grigorov <[hidden email]>
wrote:

> [ X ] Yes, release Apache Wicket 7.7.0
>
> Tested:
> - build from source
> - Wicket JQuery Selectors, Webjars && Bootstrap
> - Build and stage WicketStuff
> - my daily job main application
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Sat, Apr 15, 2017 at 10:38 PM, Andrea Del Bene <[hidden email]>
> wrote:
>
> > This is a vote to release Apache Wicket 7.7.0
> >
> > Please download the source distributions found in our staging area
> > linked below.
> >
> > I have included the signatures for both the source archives. This vote
> > lasts for 72 hours minimum.
> >
> > [ ] Yes, release Apache Wicket 7.7.0
> > [ ] No, don't release Apache Wicket 7.7.0, because ...
> >
> > Distributions, changelog, keys and signatures can be found at:
> >
> >     https://dist.apache.org/repos/dist/dev/wicket/7.7.0
> >
> > Staging repository:
> >
> > https://repository.apache.org/content/repositories/orgapachewicket-1087
> >
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Maxim Solodovnik
+1

tested:
1) sums
2) build from sources

issues:
1) email states "Distributions, changelog, keys and signatures can be found
at", but there are no keys available, so I was unable to check signature
2) I was unable to run wicket-examples using mvn jetty:run:
[WARNING] The POM for
org.mortbay.jetty:jetty-maven-plugin:jar:8.1.21.v20160908 is missing, no
dependency information available
[WARNING] Failed to retrieve plugin descriptor for
org.mortbay.jetty:jetty-maven-plugin:8.1.21.v20160908: Plugin
org.mortbay.jetty:jetty-maven-plugin:8.1.21.v20160908 or one of its
dependencies could not be resolved: Failure to find
org.mortbay.jetty:jetty-maven-plugin:jar:8.1.21.v20160908 in
https://repo.maven.apache.org/maven2 was cached in the local repository,
resolution will not be reattempted until the update interval of central has
elapsed or updates are forced

our main project uses wicket-8, so I have no other applications to test

On Wed, Apr 19, 2017 at 2:39 PM, Sebastien <[hidden email]> wrote:

> I will try to test out tonight!
>
> On Tue, Apr 18, 2017 at 1:33 AM, Martin Grigorov <[hidden email]>
> wrote:
>
> > [ X ] Yes, release Apache Wicket 7.7.0
> >
> > Tested:
> > - build from source
> > - Wicket JQuery Selectors, Webjars && Bootstrap
> > - Build and stage WicketStuff
> > - my daily job main application
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> > On Sat, Apr 15, 2017 at 10:38 PM, Andrea Del Bene <[hidden email]>
> > wrote:
> >
> > > This is a vote to release Apache Wicket 7.7.0
> > >
> > > Please download the source distributions found in our staging area
> > > linked below.
> > >
> > > I have included the signatures for both the source archives. This vote
> > > lasts for 72 hours minimum.
> > >
> > > [ ] Yes, release Apache Wicket 7.7.0
> > > [ ] No, don't release Apache Wicket 7.7.0, because ...
> > >
> > > Distributions, changelog, keys and signatures can be found at:
> > >
> > >     https://dist.apache.org/repos/dist/dev/wicket/7.7.0
> > >
> > > Staging repository:
> > >
> > > https://repository.apache.org/content/repositories/
> orgapachewicket-1087
> > >
> >
>



--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Andrea Del Bene-3
Thank you Maxim,

I've changed the jetty version to the last available version.

On Wed, Apr 19, 2017 at 12:17 PM, Maxim Solodovnik <[hidden email]>
wrote:

> +1
>
> tested:
> 1) sums
> 2) build from sources
>
> issues:
> 1) email states "Distributions, changelog, keys and signatures can be found
> at", but there are no keys available, so I was unable to check signature
> 2) I was unable to run wicket-examples using mvn jetty:run:
> [WARNING] The POM for
> org.mortbay.jetty:jetty-maven-plugin:jar:8.1.21.v20160908 is missing, no
> dependency information available
> [WARNING] Failed to retrieve plugin descriptor for
> org.mortbay.jetty:jetty-maven-plugin:8.1.21.v20160908: Plugin
> org.mortbay.jetty:jetty-maven-plugin:8.1.21.v20160908 or one of its
> dependencies could not be resolved: Failure to find
> org.mortbay.jetty:jetty-maven-plugin:jar:8.1.21.v20160908 in
> https://repo.maven.apache.org/maven2 was cached in the local repository,
> resolution will not be reattempted until the update interval of central has
> elapsed or updates are forced
>
> our main project uses wicket-8, so I have no other applications to test
>
> On Wed, Apr 19, 2017 at 2:39 PM, Sebastien <[hidden email]> wrote:
>
> > I will try to test out tonight!
> >
> > On Tue, Apr 18, 2017 at 1:33 AM, Martin Grigorov <[hidden email]>
> > wrote:
> >
> > > [ X ] Yes, release Apache Wicket 7.7.0
> > >
> > > Tested:
> > > - build from source
> > > - Wicket JQuery Selectors, Webjars && Bootstrap
> > > - Build and stage WicketStuff
> > > - my daily job main application
> > >
> > > Martin Grigorov
> > > Wicket Training and Consulting
> > > https://twitter.com/mtgrigorov
> > >
> > > On Sat, Apr 15, 2017 at 10:38 PM, Andrea Del Bene <
> [hidden email]>
> > > wrote:
> > >
> > > > This is a vote to release Apache Wicket 7.7.0
> > > >
> > > > Please download the source distributions found in our staging area
> > > > linked below.
> > > >
> > > > I have included the signatures for both the source archives. This
> vote
> > > > lasts for 72 hours minimum.
> > > >
> > > > [ ] Yes, release Apache Wicket 7.7.0
> > > > [ ] No, don't release Apache Wicket 7.7.0, because ...
> > > >
> > > > Distributions, changelog, keys and signatures can be found at:
> > > >
> > > >     https://dist.apache.org/repos/dist/dev/wicket/7.7.0
> > > >
> > > > Staging repository:
> > > >
> > > > https://repository.apache.org/content/repositories/
> > orgapachewicket-1087
> > > >
> > >
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Sebastien
Hi Andrea, hi devs,

I think you will hate me for the delay!

Moreover I'm requesting to hold the vote conclusion until further
investigation: I have another issue with the JSON library (I could hardly
detect it before the others issues was fixed)
I'm trying to complete the investigation/test case by tonight.

Thanks in advance,
Sebastien.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Andrea Del Bene-3
Take your time. Better be sure to have fixed possible problems with json
migration.

On 21 Apr 2017 20:08, "Sebastien" <[hidden email]> wrote:

> Hi Andrea, hi devs,
>
> I think you will hate me for the delay!
>
> Moreover I'm requesting to hold the vote conclusion until further
> investigation: I have another issue with the JSON library (I could hardly
> detect it before the others issues was fixed)
> I'm trying to complete the investigation/test case by tonight.
>
> Thanks in advance,
> Sebastien.
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Sebastien
Hi again,

The issue is that pojos implementing JSONString seems to not have their
#toJSONString called during JSONObject#toString
Looking at the code does not indicates an obvious reason, and for the weird
one I have some difficulties to debug (caught the JSONException block in
debug mode, probably due to the reflection, or maybe my eclipse is dying...)

Here is a simple test case for whom would like to have a look:

    @Test
    public void testToString()
    {
        MyPojo1 myPojo1 = new MyPojo1();
        MyPojo2 myPojo2 = new MyPojo2();

        String json1 = new JSONObject(myPojo1).toString();
        String json2 = new JSONObject(myPojo2).toString(); // FIXME:
#toJSONString is never called

        Assert.assertEquals(json1,
"{\"myProp1\":\"value1\",\"myProp2\":\"value2\"}");
        Assert.assertEquals(json2,
"{\"myProp3\":\"value3\",\"myProp4\":\"value4\",\"myProp5\":\"value5\"}");
    }

    public static class MyPojo1
    {
        private String myProp1 = "value1";
        private String myProp2 = "value2";

        public MyPojo1()
        {
        }

        public String getMyProp1()
        {
            return this.myProp1;
        }

        public String getMyProp2()
        {
            return this.myProp2;
        }
    }

    public static class MyPojo2 implements JSONString
    {
        private String myProp3 = "value3";
        private String myProp4 = "value4";

        public MyPojo2()
        {
        }

        public String getMyProp3()
        {
            return this.myProp3;
        }

        public String getMyProp4()
        {
            return this.myProp4;
        }

        @Override
        public String toJSONString()
        {
            JSONObject object = new JSONObject(this);
            object.put("myProp5", "value5");

            return object.toString();
        }
    }

Best regards,
Sebastien.

On Fri, Apr 21, 2017 at 8:36 PM, Andrea Del Bene <[hidden email]>
wrote:

> Take your time. Better be sure to have fixed possible problems with json
> migration.
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Maxim Solodovnik
There is no code to call this method
I'll check it later today

WBR, Maxim
(from mobile, sorry for the typos)

On Apr 22, 2017 02:01, "Sebastien" <[hidden email]> wrote:

> Hi again,
>
> The issue is that pojos implementing JSONString seems to not have their
> #toJSONString called during JSONObject#toString
> Looking at the code does not indicates an obvious reason, and for the weird
> one I have some difficulties to debug (caught the JSONException block in
> debug mode, probably due to the reflection, or maybe my eclipse is
> dying...)
>
> Here is a simple test case for whom would like to have a look:
>
>     @Test
>     public void testToString()
>     {
>         MyPojo1 myPojo1 = new MyPojo1();
>         MyPojo2 myPojo2 = new MyPojo2();
>
>         String json1 = new JSONObject(myPojo1).toString();
>         String json2 = new JSONObject(myPojo2).toString(); // FIXME:
> #toJSONString is never called
>
>         Assert.assertEquals(json1,
> "{\"myProp1\":\"value1\",\"myProp2\":\"value2\"}");
>         Assert.assertEquals(json2,
> "{\"myProp3\":\"value3\",\"myProp4\":\"value4\",\"myProp5\":\"value5\"}");
>     }
>
>     public static class MyPojo1
>     {
>         private String myProp1 = "value1";
>         private String myProp2 = "value2";
>
>         public MyPojo1()
>         {
>         }
>
>         public String getMyProp1()
>         {
>             return this.myProp1;
>         }
>
>         public String getMyProp2()
>         {
>             return this.myProp2;
>         }
>     }
>
>     public static class MyPojo2 implements JSONString
>     {
>         private String myProp3 = "value3";
>         private String myProp4 = "value4";
>
>         public MyPojo2()
>         {
>         }
>
>         public String getMyProp3()
>         {
>             return this.myProp3;
>         }
>
>         public String getMyProp4()
>         {
>             return this.myProp4;
>         }
>
>         @Override
>         public String toJSONString()
>         {
>             JSONObject object = new JSONObject(this);
>             object.put("myProp5", "value5");
>
>             return object.toString();
>         }
>     }
>
> Best regards,
> Sebastien.
>
> On Fri, Apr 21, 2017 at 8:36 PM, Andrea Del Bene <[hidden email]>
> wrote:
>
> > Take your time. Better be sure to have fixed possible problems with json
> > migration.
> >
> >
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Maxim Solodovnik
Done:
https://github.com/openjson/openjson/commit/d2367f28cebd8f21c4a4e22faec4cab2f8a95982
Thanks for the test :)

BTW the test was modified: call new JSONObject(this) inside toJSONString()
leads to StackOverflow

On Sat, Apr 22, 2017 at 12:31 PM, Maxim Solodovnik <[hidden email]>
wrote:

> There is no code to call this method
> I'll check it later today
>
> WBR, Maxim
> (from mobile, sorry for the typos)
>
> On Apr 22, 2017 02:01, "Sebastien" <[hidden email]> wrote:
>
>> Hi again,
>>
>> The issue is that pojos implementing JSONString seems to not have their
>> #toJSONString called during JSONObject#toString
>> Looking at the code does not indicates an obvious reason, and for the
>> weird
>> one I have some difficulties to debug (caught the JSONException block in
>> debug mode, probably due to the reflection, or maybe my eclipse is
>> dying...)
>>
>> Here is a simple test case for whom would like to have a look:
>>
>>     @Test
>>     public void testToString()
>>     {
>>         MyPojo1 myPojo1 = new MyPojo1();
>>         MyPojo2 myPojo2 = new MyPojo2();
>>
>>         String json1 = new JSONObject(myPojo1).toString();
>>         String json2 = new JSONObject(myPojo2).toString(); // FIXME:
>> #toJSONString is never called
>>
>>         Assert.assertEquals(json1,
>> "{\"myProp1\":\"value1\",\"myProp2\":\"value2\"}");
>>         Assert.assertEquals(json2,
>> "{\"myProp3\":\"value3\",\"myProp4\":\"value4\",\"myProp5\":
>> \"value5\"}");
>>     }
>>
>>     public static class MyPojo1
>>     {
>>         private String myProp1 = "value1";
>>         private String myProp2 = "value2";
>>
>>         public MyPojo1()
>>         {
>>         }
>>
>>         public String getMyProp1()
>>         {
>>             return this.myProp1;
>>         }
>>
>>         public String getMyProp2()
>>         {
>>             return this.myProp2;
>>         }
>>     }
>>
>>     public static class MyPojo2 implements JSONString
>>     {
>>         private String myProp3 = "value3";
>>         private String myProp4 = "value4";
>>
>>         public MyPojo2()
>>         {
>>         }
>>
>>         public String getMyProp3()
>>         {
>>             return this.myProp3;
>>         }
>>
>>         public String getMyProp4()
>>         {
>>             return this.myProp4;
>>         }
>>
>>         @Override
>>         public String toJSONString()
>>         {
>>             JSONObject object = new JSONObject(this);
>>             object.put("myProp5", "value5");
>>
>>             return object.toString();
>>         }
>>     }
>>
>> Best regards,
>> Sebastien.
>>
>> On Fri, Apr 21, 2017 at 8:36 PM, Andrea Del Bene <[hidden email]>
>> wrote:
>>
>> > Take your time. Better be sure to have fixed possible problems with json
>> > migration.
>> >
>> >
>>
>


--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Tobias Soloschenko
Yes also a big thanks from me - and apologize that after the switch from json.org to openjson so many issues came up.

kind regards

Tobias

> Am 22.04.2017 um 14:14 schrieb Maxim Solodovnik <[hidden email]>:
>
> Done:
> https://github.com/openjson/openjson/commit/d2367f28cebd8f21c4a4e22faec4cab2f8a95982
> Thanks for the test :)
>
> BTW the test was modified: call new JSONObject(this) inside toJSONString()
> leads to StackOverflow
>
> On Sat, Apr 22, 2017 at 12:31 PM, Maxim Solodovnik <[hidden email]>
> wrote:
>
>> There is no code to call this method
>> I'll check it later today
>>
>> WBR, Maxim
>> (from mobile, sorry for the typos)
>>
>>> On Apr 22, 2017 02:01, "Sebastien" <[hidden email]> wrote:
>>>
>>> Hi again,
>>>
>>> The issue is that pojos implementing JSONString seems to not have their
>>> #toJSONString called during JSONObject#toString
>>> Looking at the code does not indicates an obvious reason, and for the
>>> weird
>>> one I have some difficulties to debug (caught the JSONException block in
>>> debug mode, probably due to the reflection, or maybe my eclipse is
>>> dying...)
>>>
>>> Here is a simple test case for whom would like to have a look:
>>>
>>>    @Test
>>>    public void testToString()
>>>    {
>>>        MyPojo1 myPojo1 = new MyPojo1();
>>>        MyPojo2 myPojo2 = new MyPojo2();
>>>
>>>        String json1 = new JSONObject(myPojo1).toString();
>>>        String json2 = new JSONObject(myPojo2).toString(); // FIXME:
>>> #toJSONString is never called
>>>
>>>        Assert.assertEquals(json1,
>>> "{\"myProp1\":\"value1\",\"myProp2\":\"value2\"}");
>>>        Assert.assertEquals(json2,
>>> "{\"myProp3\":\"value3\",\"myProp4\":\"value4\",\"myProp5\":
>>> \"value5\"}");
>>>    }
>>>
>>>    public static class MyPojo1
>>>    {
>>>        private String myProp1 = "value1";
>>>        private String myProp2 = "value2";
>>>
>>>        public MyPojo1()
>>>        {
>>>        }
>>>
>>>        public String getMyProp1()
>>>        {
>>>            return this.myProp1;
>>>        }
>>>
>>>        public String getMyProp2()
>>>        {
>>>            return this.myProp2;
>>>        }
>>>    }
>>>
>>>    public static class MyPojo2 implements JSONString
>>>    {
>>>        private String myProp3 = "value3";
>>>        private String myProp4 = "value4";
>>>
>>>        public MyPojo2()
>>>        {
>>>        }
>>>
>>>        public String getMyProp3()
>>>        {
>>>            return this.myProp3;
>>>        }
>>>
>>>        public String getMyProp4()
>>>        {
>>>            return this.myProp4;
>>>        }
>>>
>>>        @Override
>>>        public String toJSONString()
>>>        {
>>>            JSONObject object = new JSONObject(this);
>>>            object.put("myProp5", "value5");
>>>
>>>            return object.toString();
>>>        }
>>>    }
>>>
>>> Best regards,
>>> Sebastien.
>>>
>>> On Fri, Apr 21, 2017 at 8:36 PM, Andrea Del Bene <[hidden email]>
>>> wrote:
>>>
>>>> Take your time. Better be sure to have fixed possible problems with json
>>>> migration.
>>>>
>>>>
>>>
>>
>
>
> --
> WBR
> Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Sebastien
In reply to this post by Maxim Solodovnik
Hi Maxim,

Thanks for your prompt action :)
This is also needed to be backported in wicket7.x / 6.x, but...

Yes, about the test, it's a corner case that could logically leads to a
stack overflow. But the fact is that it used to work like this before,
that's why I included it in the test...

Question: does the object need to process toJSONString at the ctor, or
should it only copy existing properties and then call toJSONString on
toString time.
If the API does not behave like before, this will lead to a *silent* API
break in wicket 6 &7... WDYT ?

Thanks & best regards,
Sebastien.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Maxim Solodovnik
Not sure I got your question :( could you please provide an example?

OpenJson already introduces API break(s), this one can be documented if you
feel it is required

On Sat, Apr 22, 2017 at 8:40 PM, Sebastien <[hidden email]> wrote:

> Hi Maxim,
>
> Thanks for your prompt action :)
> This is also needed to be backported in wicket7.x / 6.x, but...
>
> Yes, about the test, it's a corner case that could logically leads to a
> stack overflow. But the fact is that it used to work like this before,
> that's why I included it in the test...
>
> Question: does the object need to process toJSONString at the ctor, or
> should it only copy existing properties and then call toJSONString on
> toString time.
> If the API does not behave like before, this will lead to a *silent* API
> break in wicket 6 &7... WDYT ?
>
> Thanks & best regards,
> Sebastien.
>



--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Sebastien
Hi Maxim,

Actually there was 2 questions, that's why it was not clear :)

1/ About how to handle the stack overflow. I saw here [1] that you handle
"instanceof JSONString" in the ctor. My question was about the accuracy of
this. Should it be handled in the ctor like this, or should it be handled
in the toString method. I prefer the second method because new
JSONObject(bean) should handle real bean properties, not the properties
that may have been set manually in toJSONString

2/ API break about renaming package or method signature changes is one
thing. Silent breaks are something else. If it is documented, that's fine.
But if it can be avoided and keep compatibility... that's better IMO :)

Thanks :)
Sebastien.

[1]
https://github.com/openjson/openjson/commit/d2367f28cebd8f21c4a4e22faec4cab2f8a95982#diff-d1df85e7c46815227f1dcb2b4b08ab33R204
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Maxim Solodovnik
Actually I thought toJSONString method is required to provide correct way
of creating JSONObject from bean.
In this case I see no reason why we should scan bean itself ....

On Sat, Apr 22, 2017 at 9:04 PM, Sebastien <[hidden email]> wrote:

> Hi Maxim,
>
> Actually there was 2 questions, that's why it was not clear :)
>
> 1/ About how to handle the stack overflow. I saw here [1] that you handle
> "instanceof JSONString" in the ctor. My question was about the accuracy of
> this. Should it be handled in the ctor like this, or should it be handled
> in the toString method. I prefer the second method because new
> JSONObject(bean) should handle real bean properties, not the properties
> that may have been set manually in toJSONString
>
> 2/ API break about renaming package or method signature changes is one
> thing. Silent breaks are something else. If it is documented, that's fine.
> But if it can be avoided and keep compatibility... that's better IMO :)
>
> Thanks :)
> Sebastien.
>
> [1]
> https://github.com/openjson/openjson/commit/d2367f28cebd8f21c4a4e22faec4ca
> b2f8a95982#diff-d1df85e7c46815227f1dcb2b4b08ab33R204
>



--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Sebastien
To me, toJSONString transform a bean a its json string representation, but
the reciprocity is not true. That's a double edged question, I'm not sure
we can guess the answer 100% right. Maybe we should see what/if the jsr
says something about this...


On Apr 22, 2017 16:07, "Maxim Solodovnik" <[hidden email]> wrote:

Actually I thought toJSONString method is required to provide correct way
of creating JSONObject from bean.
In this case I see no reason why we should scan bean itself ....

On Sat, Apr 22, 2017 at 9:04 PM, Sebastien <[hidden email]> wrote:

> Hi Maxim,
>
> Actually there was 2 questions, that's why it was not clear :)
>
> 1/ About how to handle the stack overflow. I saw here [1] that you handle
> "instanceof JSONString" in the ctor. My question was about the accuracy of
> this. Should it be handled in the ctor like this, or should it be handled
> in the toString method. I prefer the second method because new
> JSONObject(bean) should handle real bean properties, not the properties
> that may have been set manually in toJSONString
>
> 2/ API break about renaming package or method signature changes is one
> thing. Silent breaks are something else. If it is documented, that's fine.
> But if it can be avoided and keep compatibility... that's better IMO :)
>
> Thanks :)
> Sebastien.
>
> [1]
> https://github.com/openjson/openjson/commit/d2367f28cebd8f21c4a4e22faec4ca
> b2f8a95982#diff-d1df85e7c46815227f1dcb2b4b08ab33R204
>



--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Maxim Solodovnik
This is the thing I don't understand :(

to/from string is standard way of serializing/deserializing JSONObject
The original issue was regarding JSONObject constructing from "Bean
instanceof JSONString"
It make sense, Bean provide desired method of "being JSONObject", we should
use this method in constructor

Maybe this discussion should be moved to github? so other openjson
contributors can participate?

On Sun, Apr 23, 2017 at 1:51 AM, Sebastien <[hidden email]> wrote:

> To me, toJSONString transform a bean a its json string representation, but
> the reciprocity is not true. That's a double edged question, I'm not sure
> we can guess the answer 100% right. Maybe we should see what/if the jsr
> says something about this...
>
>
> On Apr 22, 2017 16:07, "Maxim Solodovnik" <[hidden email]> wrote:
>
> Actually I thought toJSONString method is required to provide correct way
> of creating JSONObject from bean.
> In this case I see no reason why we should scan bean itself ....
>
> On Sat, Apr 22, 2017 at 9:04 PM, Sebastien <[hidden email]> wrote:
>
> > Hi Maxim,
> >
> > Actually there was 2 questions, that's why it was not clear :)
> >
> > 1/ About how to handle the stack overflow. I saw here [1] that you handle
> > "instanceof JSONString" in the ctor. My question was about the accuracy
> of
> > this. Should it be handled in the ctor like this, or should it be handled
> > in the toString method. I prefer the second method because new
> > JSONObject(bean) should handle real bean properties, not the properties
> > that may have been set manually in toJSONString
> >
> > 2/ API break about renaming package or method signature changes is one
> > thing. Silent breaks are something else. If it is documented, that's
> fine.
> > But if it can be avoided and keep compatibility... that's better IMO :)
> >
> > Thanks :)
> > Sebastien.
> >
> > [1]
> > https://github.com/openjson/openjson/commit/
> d2367f28cebd8f21c4a4e22faec4ca
> > b2f8a95982#diff-d1df85e7c46815227f1dcb2b4b08ab33R204
> >
>
>
>
> --
> WBR
> Maxim aka solomax
>



--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [VOTE] Release Apache Wicket 7.7.0

Sebastien
Hi Maxim,

Here we are: https://github.com/openjson/openjson/issues/8
Hope the explanation in there makes my idea clearer! :)

Thanks a lot,
Sebastien.

On Sun, Apr 23, 2017 at 5:47 AM, Maxim Solodovnik <[hidden email]>
wrote:

> This is the thing I don't understand :(
>
> to/from string is standard way of serializing/deserializing JSONObject
> The original issue was regarding JSONObject constructing from "Bean
> instanceof JSONString"
> It make sense, Bean provide desired method of "being JSONObject", we should
> use this method in constructor
>
> Maybe this discussion should be moved to github? so other openjson
> contributors can participate?
>
Loading...