[ wicket-Bugs-1576132 ] input name="submit" messing forms up

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ wicket-Bugs-1576132 ] input name="submit" messing forms up

SourceForge.net
Bugs item #1576132, was opened at 2006-10-12 22:10
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1576132&group_id=119783

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Stefan Kanev (skanev)
Assigned to: Nobody/Anonymous (nobody)
Summary: input name="submit" messing forms up

Initial Comment:
This is a JavaScript issue with HTML code like this one:

<form id="myForm">
  <input type="submit" name="submit" />
</form>

<script type="text/javascript">
  myForm = document.myForm;

  alsert(myForm.submit);
</script>

the myForm.submit refers to the input, not the function
that would submit the form. so, myForm.submit() doesn't
really do anything. Instead, it produces hard-to-trace
errors when you have FormComponents with id "submit".
It is a common pitfall that is easy for people with
JavaScript background to evade, but new developers can
have a hard time understanding why
SubmitLink/AjaxSubmitLink doesn't work for them.

I think it will be wonderful, if Wicket doesn't allow
FormComponents named 'submit' and throws a exception
for trying to make one. This isn't fool-proof, since if
the user does <input name="submit" /> without attaching
any wicket component to it, it will still resolve to
the same error.

Alternatively, the form submitting java script might be
changed, so it does if (typeof form.submit !=
'function')  so it can display a good error message to
the user.

----------------------------------------------------------------------

You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1576132&group_id=119783

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Wicket-develop mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/wicket-develop